Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CMD-97 add content to news page #869

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

wesleyboar
Copy link
Member

Overview

Allow CMS editor to add content to (top of) news page.

Related

Changes

  • added placeholder fixed_content
  • changed blog content to render in fixed_content

Testing

  1. Have a Blog installed.

  2. Verify main Blog list page can have unique content above Blog content.
    1. Load main Blog list page (example) as editor.
    2. Add content to main Blog list page.
    3. Verify content appears above the Blog content.
    4. Visit other Blog pages:
    5. Verify new content does not appear.
  3. Verify other blog pages can not have unique content above Blog article.
    1. Load other Blog pages as editor:
    2. Try to add content to page.
    3. Verify content can not be added above Blog content.

UI

wesleyboar and others added 30 commits July 19, 2024 15:54
NOT WORKING! Fails with:

> NoReverseMatch at /feed/
> '' is not a registered namespace
Fails, because it renders nothing.
Load `/blog/remote`.

BREAKING CHANGE: Changed `/blog` to `/blog/local`
⚠️ Does NOT render feed items.
This reverts commit 6bece39.

This did not fix anything. `SESSION_COOKIE_SECURE=False` is still required locally.
- ✓ fix links to articles
- ✓ fix pagination links
@wesleyboar wesleyboar added feature A new feature or replacement of present feature effort M Medium effort task (~1 week) — does not include review time labels Sep 12, 2024
@wesleyboar wesleyboar marked this pull request as ready for review September 12, 2024 18:34
@wesleyboar wesleyboar marked this pull request as draft September 12, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort M Medium effort task (~1 week) — does not include review time feature A new feature or replacement of present feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant