Bug/WP-261: Search bar component - fix js warnings related to button usage

[chandra-tacc]

Overview

Button has a validation that the children property is a string.

Related

• WP-261

Changes

• collapse the span into the button and set the test id
• Ensure the button text is a string
• Adjust unit tests

Testing

1. Run this test before and after the fix and ensure there are no warnings: npm run test -- client/src/components/_common/Searchbar/Searchbar.test.jsx
2. In the UI, go to a data file browser, https://cep.test/workbench/data/tapis/community/cloud.data/corral/tacc/aci/CEP/community/ and search. There should be Back to All Files button link in the top. It should work.

UI

Notes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.09%. Comparing base (f946847) to head (078a9df).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #974   +/-   ##
=======================================
  Coverage   73.09%   73.09%           
=======================================
  Files         531      531           
  Lines       33150    33152    +2     
  Branches     2922     2922           
=======================================
+ Hits        24230    24232    +2     
  Misses       8726     8726           
  Partials      194      194           

Flag	Coverage Δ
javascript	76.12% <100.00%> (+<0.01%)	⬆️
unittests	60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...ent/src/components/_common/Searchbar/Searchbar.jsx	93.75% <100.00%> (+0.07%)	⬆️

[wesleyboar]

Provided button UI has not changed, this is great. I do not know why buttons have internal <span> tags.

[van-go]

LGTM. I ran the test in main and this branch. This branch has no warnings.
One note, the test should be:
npm run test -- src/components/_common/Searchbar/Searchbar.test.jsx