Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-265 and WP-266 - tickets tests js warnings #975

Merged
merged 8 commits into from
Oct 9, 2024

Conversation

chandra-tacc
Copy link
Collaborator

@chandra-tacc chandra-tacc commented Sep 27, 2024

Overview

Pass in required parameter to components. This resolves warnings in ticket components

Related

WP-265
WP-266

Changes

  • Update tests to include the required parameters.

Testing

  1. Run this before and after the PR: npm run test -- src/components/Tickets

UI

Notes

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.09%. Comparing base (b085297) to head (3090a14).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #975   +/-   ##
=======================================
  Coverage   73.08%   73.09%           
=======================================
  Files         531      531           
  Lines       33150    33150           
  Branches     2926     2922    -4     
=======================================
+ Hits        24228    24230    +2     
+ Misses       8728     8726    -2     
  Partials      194      194           
Flag Coverage Δ
javascript 76.12% <ø> (+<0.01%) ⬆️
unittests 60.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@chandra-tacc chandra-tacc marked this pull request as ready for review September 27, 2024 19:26
chandra-tacc and others added 7 commits September 27, 2024 14:40
* update depdendencies and vite config

* fix tests for vitest compatibility

* use vites in npm commands

* add test coverage

* fix CI linting

* remove jest config

* remove debug logging
Bumps [rollup](https://github.com/rollup/rollup) from 2.70.1 to 2.79.2.
- [Release notes](https://github.com/rollup/rollup/releases)
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md)
- [Commits](rollup/rollup@v2.70.1...v2.79.2)

---
updated-dependencies:
- dependency-name: rollup
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [django](https://github.com/django/django) from 4.2.15 to 4.2.16.
- [Commits](django/django@4.2.15...4.2.16)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link
Contributor

@van-go van-go left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandra-tacc chandra-tacc merged commit f946847 into main Oct 9, 2024
6 checks passed
@chandra-tacc chandra-tacc deleted the bugs/js-warnings-ticket-tests branch October 9, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants