Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

harden github actions workflows #183

Merged
merged 61 commits into from
Jul 5, 2023
Merged

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 5, 2023

Overview

Refactor gitflow actions for labels to be functional, easy to read, consistent, and less verbose.

Related

Builds upon:

Same functionality as:

Changes

  • wrap assigner and checker in two simple wrappers
  • add comments
  • reduce name verbosity

Testing

  1. Open PR with label set before clicking "Create pull request".
  2. Check PR label checker is run.
  3. Remove label from PR.
  4. Check PR label checker is run.
  5. Close & Reopen PR.
  6. Check PR label checker is not run.
  7. Add label.
  8. Check PR label checker is run.

UI

N/A

Notes

Originally built following https://tiagomichaelsousa.dev/articles/stop-writing-your-changelogs-manually, but I made updates.

Known Issues

  1. 🤷 After PR close, label remove, pr reopen; one label check will fail, because it runs before pr-open–triggered assignment finishes. No solution known besides making action run again (by manually re-running or by removing and adding label).
  2. ❌ The changelog-updater.yaml is still untested did not update CHANGELOG.md.

@github-actions github-actions bot added the chore Changes with no (or minimal) user-facing effect label Jul 5, 2023
@wesleyboar wesleyboar closed this Jul 5, 2023
@wesleyboar wesleyboar removed the chore Changes with no (or minimal) user-facing effect label Jul 5, 2023
@wesleyboar wesleyboar reopened this Jul 5, 2023
@github-actions github-actions bot added the chore Changes with no (or minimal) user-facing effect label Jul 5, 2023
@wesleyboar wesleyboar closed this Jul 5, 2023
@wesleyboar wesleyboar removed the chore Changes with no (or minimal) user-facing effect label Jul 5, 2023
@wesleyboar wesleyboar reopened this Jul 5, 2023
@github-actions github-actions bot added the chore Changes with no (or minimal) user-facing effect label Jul 5, 2023
@wesleyboar wesleyboar closed this Jul 5, 2023
@wesleyboar wesleyboar removed the chore Changes with no (or minimal) user-facing effect label Jul 5, 2023
@wesleyboar wesleyboar reopened this Jul 5, 2023
@github-actions github-actions bot added the chore Changes with no (or minimal) user-facing effect label Jul 5, 2023
@wesleyboar wesleyboar removed the chore Changes with no (or minimal) user-facing effect label Jul 5, 2023
@wesleyboar wesleyboar closed this Jul 5, 2023
@wesleyboar wesleyboar reopened this Jul 5, 2023
@github-actions github-actions bot added the chore Changes with no (or minimal) user-facing effect label Jul 5, 2023
@wesleyboar wesleyboar added chore Changes with no (or minimal) user-facing effect and removed chore Changes with no (or minimal) user-facing effect labels Jul 5, 2023
@wesleyboar wesleyboar removed the chore Changes with no (or minimal) user-facing effect label Jul 5, 2023
@wesleyboar wesleyboar closed this Jul 5, 2023
@wesleyboar wesleyboar reopened this Jul 5, 2023
@github-actions github-actions bot added the chore Changes with no (or minimal) user-facing effect label Jul 5, 2023
@wesleyboar wesleyboar changed the title more test and fix of github actions workflows harden github actions workflows Jul 5, 2023
@wesleyboar wesleyboar added the refactor Re-writes/structures code but retains behavior label Jul 5, 2023
@wesleyboar wesleyboar merged commit 2d8cd75 into main Jul 5, 2023
2 checks passed
@wesleyboar wesleyboar deleted the chore/test-github-workflows branch July 5, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes with no (or minimal) user-facing effect patch A backward-compatible fix refactor Re-writes/structures code but retains behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant