Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: actually set hr color / fix typo #311

Merged
merged 1 commit into from
Feb 22, 2024
Merged

hotfix: actually set hr color / fix typo #311

merged 1 commit into from
Feb 22, 2024

Conversation

wesleyboar
Copy link
Member

Overview

Fix typo. Set color to match what has been shown.

Related

Changes

  • fixed CSS that was inactive

Testing

Demo

  1. Test an <hr> on Core-Styles demo that uses CMS stylesheet e.g. http://localhost:3002/components/detail/headings--cms.
  2. Verify HR color is set by core-styles and is similar to the color it has been.

Client

  1. Replicate changes in a client e.g. on https://tacc.utexas.edu/news/supplemental/2024/02/22/black-history-month-spotlight-cosby/?edit .
  2. Verify HR color is set by core-styles and is similar to the color it has been.

UI

Demo (CMS Headings)

Before After
broken working

Client (TACC CMS)

Before After
before after

@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Feb 22, 2024
@wesleyboar wesleyboar mentioned this pull request Feb 22, 2024
Merged
@wesleyboar wesleyboar added the patch A backward-compatible fix label Feb 22, 2024
R-Tomas-Gonzalez
R-Tomas-Gonzalez approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@R-Tomas-Gonzalez R-Tomas-Gonzalez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Tested on client and demo.

@wesleyboar wesleyboar merged commit c5e1c86 into main Feb 22, 2024
5 checks passed
@wesleyboar wesleyboar deleted the hotfix/actually-set-hr-color branch February 22, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@R-Tomas-Gonzalez R-Tomas-Gonzalez R-Tomas-Gonzalez approved these changes

Assignees
No one assigned
Labels
fix Fixes user-facing behavior or feature patch A backward-compatible fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesleyboar @R-Tomas-Gonzalez