Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/fp 1499 ui pattern demo - fix css import paths #35

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Task/fp 1499 ui pattern demo - fix css import paths #35

wants to merge 30 commits into from

Conversation

wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Jul 25, 2022 •
edited
Loading

Overview

Fix CSS import path resolution so one can locally develop/test Core-CMS pattern library.

Related

Changes

  • Change pattern lib deps type (to support cross-repo dev).
  • Only support relative paths.
  • Resolve any PostCSS config importFrom paths.
  • Use relative import for plugin testing CSS.

Testing

  1. Use solution B from Locally Develop CMS Styles.
  2. Make a change to tup-ui/libs/core-styles code that will have a visible effect.
  3. Build the Core-CMS pattern library.
    (follow "Testing" from task/FP-1499: CMS pattern library Core-CMS#512)

Screenshots / Notes

See TACC/Core-CMS#512.

This was referenced Jul 25, 2022
Closed
Closed
@wesleyboar wesleyboar changed the title Task/fp 1499 cms pattern library general fix for import paths Task/fp 1499 core-styles pattern demo - fix import paths Jul 25, 2022
@wesleyboar wesleyboar changed the title Task/fp 1499 core-styles pattern demo - fix import paths Task/fp 1499 core-styles pattern demo - fix css import paths Jul 25, 2022
@wesleyboar wesleyboar force-pushed the task/fp-1499-cms-pattern-library branch from 25d184d to 5803ef7 Compare July 25, 2022 20:02
@wesleyboar wesleyboar force-pushed the task/fp-1499-cms-pattern-library--general-fix-for-import-paths branch from e0e2df9 to c1f5d24 Compare July 25, 2022 20:02
@wesleyboar
Copy link
Member Author

Retiring this repo in favor of https://github.com/TACC/tup-ui.

@wesleyboar wesleyboar closed this Jul 28, 2022
@wesleyboar
Copy link
Member Author

https://github.com/TACC/tup-ui's core-styles directory is frozen until further notice. I revive this repo and its relevant PRs.

@wesleyboar wesleyboar reopened this Jul 29, 2022
@wesleyboar
Merge branch 'task/fp-1499-cms-pattern-library' into task/fp-1499-cms…
75e2379 
…-pattern-library--general-fix-for-import-paths
@wesleyboar wesleyboar marked this pull request as ready for review July 29, 2022 20:05
@wesleyboar wesleyboar changed the title Task/fp 1499 core-styles pattern demo - fix css import paths Task/fp 1499 ui pattern demo - fix css import paths Aug 8, 2022
Base automatically changed from task/fp-1499-cms-pattern-library to main August 16, 2022 17:34
@wesleyboar wesleyboar added the paused Started but not actively in progress label Aug 16, 2022
@wesleyboar wesleyboar added the enhancement Improvements or additions to existing features label Dec 13, 2022
@wesleyboar wesleyboar added the patch A backward-compatible fix label Jul 6, 2023
@wesleyboar
Copy link
Member Author

I do not understand the state of this PR. I make it a Draft for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Improvements or additions to existing features patch A backward-compatible fix paused Started but not actively in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wesleyboar