-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tech debt upgrade #182
Merged
Merged
Tech debt upgrade #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added context URI to breadcrumbs
[170] Display dcterms.title as one of the titles in the hierarchy of preferred titles
Co-Authored-By: rladdusaw <rladdusaw@gmail.com>
update static resource handler
- Run as a given user in the Dockerfile as soon as possible. - Specify a profile for runing as jar or war. - Use `project.parent.version`. - Add exclusions necessary for current weaver version (`2.1.1-RC9`), later versions may fix this and require removing the exclusions. - Remove org.codehaus.mojo:properties-maven-plugin because it does not appear to be used (if this is wrong then please add it back). - Use correct version for xml-apis:xml-apis, which is not obvious, and add appropriate comments describing the problem. - Upgrade versions. - Remove version numbers that need not be specified. - The junit vintage engine no longer needs to be excluded. - Add mockito dependencies and fix tests. - Add excludes that are used by SAGE for consistency across project repositories. - Add org.apache.maven.plugins:maven-compiler-plugin plugin. - Switch from 1.6.0 to 3.0.0 of org.codehaus.mojo:exec-maven-plugin. - The NPM Link and Unlink are removed as a result of the switch from 1.6.0 to 3.0.0; however, there are concerns about whether or not this can or should be done. - Favor `<>` rather than `<WebServlet>` on right side of an equal sign. - Fix application.yml spring migration related issues. - Add missing 'g' in e-mail address. - Remove unecessary `@ExtendWith(SpringExtension.class)` in cases where `@SpringBootTest` is used. - Add logback-test.xml file.
kaladay
approved these changes
Jun 21, 2022
ghost
deleted the
153-java-upgrade
branch
June 21, 2022 16:45
ghost
linked an issue
Jun 21, 2022
that may be
closed
by this pull request
6 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.