Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TL Header and Footer should not be lazy loaded. #373

Open
kaladay opened this issue Oct 19, 2021 · 0 comments
Open

TL Header and Footer should not be lazy loaded. #373

kaladay opened this issue Oct 19, 2021 · 0 comments

Comments

@kaladay
Copy link
Contributor

kaladay commented Oct 19, 2021 •
edited
Loading

The TL Footer is being lazy-loaded and does not show up until scrolling to the bottom.

The TL-Footer is expected to be fixed at the bottom of the page, so do not lazy load it.

tamu-library-components/projects/tl-elements/src/lib/core/tl-core.module.ts

Line 40 in 9e6b2d3

{ component: TlFooterComponent, selector: 'tl-footer', lazy: true },

The header likely should also be not lazy-loaded:

tamu-library-components/projects/tl-elements/src/lib/core/tl-core.module.ts

Line 41 in 9e6b2d3

{ component: TlHeaderComponent, selector: 'tl-header', lazy: true },

@kaladay kaladay changed the title TL Footer should not be lazy loaded. TL Header and Footer should not be lazy loaded. Oct 19, 2021
kaladay added a commit that referenced this issue Aug 29, 2022
@kaladay
Merge pull request #373 from TAMULib/sprint19-363-components_display
5b112b2 
[Issue 363] Weaver Components should use an alternate mechanism to display: none when components are ready.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaladay