Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Z80 debugger doesn't work with Genesis Plus GX. #4226

Open
Grandmaster9918 opened this issue Feb 14, 2025 · 2 comments
Open

Z80 debugger doesn't work with Genesis Plus GX. #4226

Grandmaster9918 opened this issue Feb 14, 2025 · 2 comments
Labels
Core: Genplus-gx Sega Genesis / Mega Drive core Request: Feature/Enhancement For feature requests or possible improvements

Comments

@Grandmaster9918
Copy link

Grandmaster9918 commented Feb 14, 2025

Summary

Loaded core: Genesis Plus GX. (Master System mode)
ROM: SHA1:9ec22b866c3df95bcef6a422aec4e5fbe396750f Baku Baku (Brazil)
Open Tools: Attempted to open debugger for this core.

Repro

  1. Open ROM
  2. Open the debugger
  3. Error Message

Output

System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.
   at System.ThrowHelper.ThrowKeyNotFoundException()
   at System.Collections.Generic.Dictionary`2.get_Item(TKey key)
   at BizHawk.Client.EmuHawk.GenericDebugger.UpdateCapabilitiesProps() in /_/src/BizHawk.Client.EmuHawk/tools/Debugger/GenericDebugger.IToolForm.cs:line 56
   at BizHawk.Client.EmuHawk.GenericDebugger.Restart() in /_/src/BizHawk.Client.EmuHawk/tools/Debugger/GenericDebugger.IToolForm.cs:line 110
   at BizHawk.Client.EmuHawk.ToolManager.Load[T](Boolean focus, String toolPath) in /_/src/BizHawk.Client.EmuHawk/tools/ToolManager.cs:line 148
   at System.Windows.Forms.ToolStripItem.RaiseEvent(Object key, EventArgs e)
   at System.Windows.Forms.ToolStripMenuItem.OnClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleClick(EventArgs e)
   at System.Windows.Forms.ToolStripItem.HandleMouseUp(MouseEventArgs e)
   at System.Windows.Forms.ToolStrip.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.ToolStripDropDown.OnMouseUp(MouseEventArgs mea)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ToolStrip.WndProc(Message& m)
   at System.Windows.Forms.ToolStripDropDown.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)

Host env.

  • BizHawk 2.10 Windows 11 AMD

Image

@YoshiRulz YoshiRulz added App: EmuHawk Relating to EmuHawk frontend Core: Genplus-gx Sega Genesis / Mega Drive core Repro: Affects 2.10 labels Feb 14, 2025
@Grandmaster9918
Copy link
Author

It should open the Z80 debugger if I am correct.

@Grandmaster9918 Grandmaster9918 changed the title (issue title -- summarise the summary) Z80 debugger doesn't work with Genesis Plus GX. Feb 14, 2025
@YoshiRulz
Copy link
Member

YoshiRulz commented Feb 14, 2025

Repro'd with a different rom.

System.Collections.Generic.KeyNotFoundException: The given key 'M68K PC' was not present in the dictionary.
  at System.Collections.Generic.Dictionary`2[TKey,TValue].get_Item (TKey key) [0x0001e] in <65a38edf81fe405bb4fb28e56b25f9d8>:0 
  at BizHawk.Client.EmuHawk.GenericDebugger.get_PCRegister () [0x00016] in <c8dfed4c06f04795b0ee2354d4b12b97>:0 
  at BizHawk.Client.EmuHawk.GenericDebugger.UpdateCapabilitiesProps () [0x00045] in <c8dfed4c06f04795b0ee2354d4b12b97>:0 
  at BizHawk.Client.EmuHawk.GenericDebugger.Restart () [0x00001] in <c8dfed4c06f04795b0ee2354d4b12b97>:0 
  at BizHawk.Client.EmuHawk.ToolManager.Load[T] (System.Boolean focus, System.String toolPath) [0x0019a] in <c8dfed4c06f04795b0ee2354d4b12b97>:0

See also #4157.

edit: Tool now opens without crashing, but query whether the disasm is correct.
edit edit: CPP says it was garbage, so I disabled disasm. Reopening as feature request.

@YoshiRulz YoshiRulz added the Reproducible bug Should only be added to issues with a `Repro: Affects` label. label Feb 14, 2025
@YoshiRulz YoshiRulz added the Repro: Fixed/added in 2.10.1 dev Fixed in dev builds, see readme for download label Feb 14, 2025
YoshiRulz added a commit that referenced this issue Feb 14, 2025
@YoshiRulz YoshiRulz added Request: Feature/Enhancement For feature requests or possible improvements and removed App: EmuHawk Relating to EmuHawk frontend Reproducible bug Should only be added to issues with a `Repro: Affects` label. Repro: Fixed/added in 2.10.1 dev Fixed in dev builds, see readme for download Repro: Affects 2.10 labels Feb 14, 2025
@YoshiRulz YoshiRulz reopened this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core: Genplus-gx Sega Genesis / Mega Drive core Request: Feature/Enhancement For feature requests or possible improvements
Projects
None yet
Development

No branches or pull requests

2 participants