Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TLS handshake failure when connection to server that requires SNI #232

Closed
marcelslotema opened this issue Mar 4, 2019 · 0 comments
Closed

TLS handshake failure when connection to server that requires SNI #232

marcelslotema opened this issue Mar 4, 2019 · 0 comments
Milestone
libtaxii 1.1.113

Comments

@marcelslotema
Copy link
Contributor

I am trying to push STIX content to a TAXII server that requires Server Name Identification (SNI). This results in a urllib error: sslv3 alert handshake failure.

If I make a plain urllib request to the same URL, I encounter no problems.

After a bit of looking around, I think the problem is in the connect method of the VerifiableHTTPSConnection class. The calls to wrap_socket do not include a server_hostname, where the connect method in the base class does.
emmanvg added a commit that referenced this issue Apr 11, 2019
@emmanvg
Merge pull request #233 from marcelslotema/master
36a7e37 
Include server hostname information when creating a HTTPS connection. Fixes #232
@emmanvg emmanvg added this to the libtaxii 1.1.113 milestone Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
libtaxii 1.1.113
Development

No branches or pull requests
2 participants
@emmanvg @marcelslotema