Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple spec changes - support for aka, controller, ; -> , & list of service endpoints #86

Merged
merged 3 commits into from
Jan 8, 2024
Merged

Multiple spec changes - support for aka, controller, ; -> , & list of service endpoints #86

merged 3 commits into from
Jan 8, 2024

Conversation

decentralgabe
Copy link
Member

@decentralgabe decentralgabe commented Jan 5, 2024 •
edited
Loading

Fix #79, #85, and more

  • change , to ; (commas separate lists, ;'s separate elements) as per Consider adjustment to TXT RData format #79
  • add # as a WYSIWYG property for key ids and service ids
  • support service endpoints being single value or array
  • support other properties in service endpoints in the same record
  • add guidance on representing records for AKA and controller properties
  • updated test vectors

@decentralgabe decentralgabe linked an issue Jan 5, 2024 that may be closed by this pull request
Support multiple service endpoints in a single service property #85
Closed
@decentralgabe decentralgabe merged commit 507e524 into main Jan 8, 2024
4 checks passed
@decentralgabe decentralgabe deleted the issue-85 branch January 8, 2024 16:40
This was referenced Jan 8, 2024
Open
Closed
Closed
This was referenced Apr 23, 2024
Open
Open
Open
Open
Open
@diehuxx diehuxx mentioned this pull request Apr 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankhinek frankhinek frankhinek approved these changes

@mistermoe mistermoe mistermoe approved these changes

@csuwildcat csuwildcat Awaiting requested review from csuwildcat csuwildcat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
SDK Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support multiple service endpoints in a single service property Consider adjustment to TXT RData format
3 participants
@decentralgabe @frankhinek @mistermoe