Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RecordsWrite with no data should return a 204 status code. #695

Closed
LiranCohen opened this issue Feb 26, 2024 · 0 comments · Fixed by #790
Closed

RecordsWrite with no data should return a 204 status code. #695

LiranCohen opened this issue Feb 26, 2024 · 0 comments · Fixed by #790
Labels
good first issue Good for newcomers

Comments

@LiranCohen
Copy link
Member

LiranCohen commented Feb 26, 2024

Currently when you write a RecordsWrite without any data, we assume that this is an initial write and the record will not be returned in a query.

When debugging issues, it could be difficult to discern between something that was accepted as a queryable write and something that was accepted as an initial state.

In discussing with @csuwildcat we decided a 204 - No Content response to writing a record with no data would be most suitable for signaling this.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Status/204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant