Return 204 when there is no data #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresuribe87
requested review from
mistermoe,
csuwildcat,
thehenrytsai and
LiranCohen
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 73 73
Lines 11264 11269 +5
Branches 1609 1612 +3
=======================================
+ Hits 11117 11122 +5
Misses 141 141
Partials 6 6 ☔ View full report in Codecov by Sentry. |
andresuribe87
commented
Aug 7, 2024
|
@LiranCohen ready for review. Would appreciate some 👀 ! |
LiranCohen
reviewed
Aug 7, 2024
LiranCohen
previously approved these changes
Aug 7, 2024
|
@LiranCohen is it cool to merge bypassing branch protections? |
|
NOTE: The CVE was discovered in, and is being fixed by this PR waiting to be merged: Therefore I am bypassing the branch protections for merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #695
Additionally, changes the
scripts.testvalue so that source maps are correct and point to the actual implementation files instead of the transpiled JS files.