Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MessagesGet #313

Merged
merged 13 commits into from
Apr 20, 2023
Merged

MessagesGet #313

merged 13 commits into from
Apr 20, 2023

Conversation

mistermoe
Copy link
Member

Final PR to round out sync foundations. preceded by #305

Introduces an MessagesGet message to retrieve messages. Will include more details in this description tmrw. brain is total mush right now.

@mistermoe mistermoe linked an issue Apr 16, 2023 that may be closed by this pull request
Implement Sync #14
Closed
@mistermoe mistermoe requested a review from dcrousso April 16, 2023 06:53
diehuxx
diehuxx reviewed Apr 16, 2023
View reviewed changes
Copy link

@diehuxx diehuxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking solid! no major issues, just an assortment of small things.

dcrousso
dcrousso previously approved these changes Apr 16, 2023
View reviewed changes
src/interfaces/messages/handlers/messages-get.ts Show resolved Hide resolved
src/interfaces/messages/handlers/messages-get.ts Show resolved Hide resolved
src/interfaces/messages/messages/messages-get.ts Show resolved Hide resolved
src/interfaces/messages/messages/messages-get.ts Outdated Show resolved Hide resolved
src/interfaces/records/handlers/records-delete.ts Outdated Show resolved Hide resolved
src/interfaces/messages/handlers/messages-get.ts Outdated Show resolved Hide resolved
src/interfaces/messages/types.ts Show resolved Hide resolved
diehuxx
diehuxx previously approved these changes Apr 17, 2023
View reviewed changes
thehenrytsai
thehenrytsai approved these changes Apr 20, 2023
View reviewed changes
Copy link
Member

@thehenrytsai thehenrytsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! 🙇

@mistermoe mistermoe merged commit 07bcddb into main Apr 20, 2023
@mistermoe mistermoe deleted the messages-get branch April 20, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelneale michaelneale michaelneale left review comments

@dcrousso dcrousso dcrousso left review comments

@diehuxx diehuxx diehuxx left review comments

@thehenrytsai thehenrytsai thehenrytsai approved these changes

@csuwildcat csuwildcat Awaiting requested review from csuwildcat csuwildcat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Sync
5 participants
@mistermoe @michaelneale @dcrousso @thehenrytsai @diehuxx