Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#333 #326 Refactor protocol recordTypes #337

Merged
merged 7 commits into from
May 4, 2023
Merged

Conversation

diehuxx
Copy link

@diehuxx diehuxx commented May 2, 2023

Another step in the refactor outlined in #326. Also, fully addresses feature #333.

Changes

#326

  • Change property label to recordDefinitions. Make recordDefinitions an array, where each element has id, schema, and dataFormats

#333

  • Makes schema optional in protocol auth'd RecordsWrites. (schema was previously required for protocol RecordsWrites.)

Other

  • Remove duplicate tests and flesh out tests for ProtocolAuthrorization.getRuleSet, particularly testing for new error code DwnErrorCode.ProtocolAuthorizationMissingRuleSet.

@diehuxx diehuxx marked this pull request as ready for review May 2, 2023 20:17
csuwildcat
csuwildcat previously approved these changes May 2, 2023
thehenrytsai
thehenrytsai previously approved these changes May 4, 2023
@diehuxx diehuxx merged commit f8a150e into main May 4, 2023
@diehuxx diehuxx deleted the diehuxx/protocol-record-types branch June 23, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants