Create and process PermissionsGrant messages #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehuxx
requested review from
mistermoe,
csuwildcat and
thehenrytsai
as code owners
diehuxx
force-pushed
the
diehuxx/permissions-grant
branch
from
8cd25a5
to
bd53b14
Compare
src/handlers/permissions-grant.ts
Outdated
| } | ||
|
|
||
| // validate PermissionsRequestId if it is included | ||
| if (message.descriptor.permissionsRequestId !== undefined) { |
There was a problem hiding this comment.
Given that permissionsRequestId is optional, I wonder how practically useful it is, my theory is that it is not very, and thus if you agree, am leaning towards removing it for now.
thehenrytsai
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates and processes
PermissionsGrantmessages. It does NOT implement grant-based authorization of other DWN messages. That'll be added in the next PR.