Create and process PermissionsRevoke #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehuxx
requested review from
mistermoe,
csuwildcat and
thehenrytsai
as code owners
diehuxx
commented
Jun 28, 2023
diehuxx
commented
Jun 28, 2023
diehuxx
commented
Jun 28, 2023
diehuxx
force-pushed
the
diehuxx/permissions-revoke
branch
from
ba45e8c
to
09aa2af
Compare
Co-authored-by: Henry Tsai <henrytsai@outlook.com>
diehuxx
force-pushed
the
diehuxx/permissions-revoke
branch
from
6620b27
to
7fce19e
Compare
thehenrytsai
reviewed
Jul 3, 2023
thehenrytsai
reviewed
Jul 4, 2023
added 2 commits
July 5, 2023 12:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step in implementing TP26.
This adds creation and processing of
PermissionsRevokemessage, but does NOT add grant-based authorization. That will be in the next PR, which will also boost test coverage for some scenarios inPermissionsRevokeHandlerwhich are not currently reachable.