Missing JSON Schema properties for Permission Scopes #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LiranCohen
requested review from
mistermoe,
csuwildcat and
thehenrytsai
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #781 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 73 73
Lines 11264 11264
Branches 1609 1609
=======================================
Hits 11117 11117
Misses 141 141
Partials 6 6 ☔ View full report in Codecov by Sentry. |
thehenrytsai
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some missing schema properties expected in the various protocol scopes.
I wrote tests that validate that the messages are processed, but I think there need to be some additional testing regarding the functionality of various scopes in a subsequent PR/Issue.