Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

construction of grants and requests are not async #791

Closed
wants to merge 1 commit into from

Conversation

LiranCohen
Copy link
Member

@LiranCohen LiranCohen commented Aug 11, 2024

Currently PermissionGrant and PermissionRequest have an async parse() method to instantiate them with a private constructor.

However there is currently no async action needed to parse the grant/request. Any objection to removing the parse() method in favor of just using the constructor?

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (39c485c) to head (1c0c8d7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #791      +/-   ##
==========================================
- Coverage   98.69%   98.69%   -0.01%     
==========================================
  Files          73       73              
  Lines       11269    11259      -10     
  Branches     1612     1610       -2     
==========================================
- Hits        11122    11112      -10     
  Misses        141      141              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LiranCohen LiranCohen force-pushed the lirancohen/grants-parse-not-async branch from b75e8d3 to 1c0c8d7 Compare August 14, 2024 16:33
@LiranCohen LiranCohen marked this pull request as ready for review August 14, 2024 16:34
@LiranCohen
Copy link
Member Author

Keeping the pattern of async parse() over constructors.

@LiranCohen LiranCohen closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants