Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dwn-sdk-js to v0.2.6 #9

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Conversation

diehuxx
Copy link

@diehuxx diehuxx commented Nov 2, 2023

No description provided.

@amika-sq
Copy link
Collaborator

amika-sq commented Nov 3, 2023

@diehuxx do you know if anything changed in the latest dwn release that might be causing this? https://github.com/TBD54566975/dwn-sql-store/actions/runs/6738388710/job/18317854886?pr=9

I did a quick look, and it doesn't seem like anything of note changed with our signing algorithms. Will take a closer look into what might be the cause here 🤔

@diehuxx
Copy link
Author

diehuxx commented Nov 6, 2023

@amika-sq No changes AFAIK to signing algorithms. We made some changes to where we put the JWS in the DWN message, but that should be orthogonal / wouldn't likely produce that error message.

@diehuxx
Copy link
Author

diehuxx commented Nov 6, 2023

Seems like a circular dependency issue that arose as a result of this PR. TBD54566975/dwn-sdk-js#591. We are importing from index.js in ed25519.ts.

I'll put a up a PR in dwn-sdk-js fixing and bumping the dwn-sdk-js version.

@diehuxx diehuxx changed the title Bump dwn-sdk-js to v0.2.5 Bump dwn-sdk-js to v0.2.6 Nov 6, 2023
Copy link
Member

@LiranCohen LiranCohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #9 (f982683) into main (f36d8a3) will increase coverage by 0.87%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   80.02%   80.89%   +0.87%     
==========================================
  Files          10       10              
  Lines         956      958       +2     
  Branches      140      142       +2     
==========================================
+ Hits          765      775      +10     
+ Misses        191      183       -8     

@LiranCohen LiranCohen merged commit 68b1a81 into TBD54566975:main Nov 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants