-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dwn-sdk-js to v0.2.6 #9
Conversation
@diehuxx do you know if anything changed in the latest dwn release that might be causing this? https://github.com/TBD54566975/dwn-sql-store/actions/runs/6738388710/job/18317854886?pr=9 I did a quick look, and it doesn't seem like anything of note changed with our signing algorithms. Will take a closer look into what might be the cause here 🤔 |
@amika-sq No changes AFAIK to signing algorithms. We made some changes to where we put the JWS in the DWN message, but that should be orthogonal / wouldn't likely produce that error message. |
Seems like a circular dependency issue that arose as a result of this PR. TBD54566975/dwn-sdk-js#591. We are importing from I'll put a up a PR in dwn-sdk-js fixing and bumping the dwn-sdk-js version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 80.02% 80.89% +0.87%
==========================================
Files 10 10
Lines 956 958 +2
Branches 140 142 +2
==========================================
+ Hits 765 775 +10
+ Misses 191 183 -8 |
No description provided.