add istio test

backend/controller/scaling/k8sscaling/deployment_provisioner.go

@@ -288,6 +288,7 @@ func (r *DeploymentProvisioner) handleNewDeployment(ctx context.Context, dep *sc
 		change(deployment)
 	}
 	deployment.Labels = addLabel(deployment.Labels, deploymentLabel, name)
+	deployment.Labels = addLabel(deployment.Labels, "app", name)
 
 	deployment, err = deploymentClient.Create(ctx, deployment, v1.CreateOptions{})
 	if err != nil {

backend/controller/scaling/kube_scaling_integration_test.go

@@ -5,6 +5,7 @@ package scaling_test
 import (
 	"context"
 	"fmt"
+	"strconv"
 	"strings"
 	"sync"
 	"testing"
@@ -31,13 +32,31 @@ func runKubeScalingTest(t *testing.T, istio bool) {
 	done.Store(false)
 	routineStopped := sync.WaitGroup{}
 	routineStopped.Add(1)
+	echoDeployment := map[string]string{}
 	in.Run(t,
 		in.WithIstio(istio),
 		in.CopyModule("echo"),
 		in.Deploy("echo"),
+		in.CopyModule("naughty"),
+		in.Deploy("naughty"),
 		in.Call("echo", "echo", "Bob", func(t testing.TB, response string) {
 			assert.Equal(t, "Hello, Bob!!!", response)
 		}),
+		in.VerifyKubeState(func(ctx context.Context, t testing.TB, namespace string, client *kubernetes.Clientset) {
+			deps, err := client.AppsV1().Deployments(namespace).List(ctx, v1.ListOptions{})
+			assert.NoError(t, err)
+			for _, dep := range deps.Items {
+				if strings.HasPrefix(dep.Name, "dpl-echo") {
+					echoDeployment["name"] = dep.Name
+				}
+			}
+			assert.NotEqual(t, "", echoDeployment["name"])
+		}),
+		in.Call("naughty", "beNaughty", echoDeployment, func(t testing.TB, response string) {
+			// If istio is not present we should be able to ping the echo service directly.
+			// Istio should prevent this
+			assert.Equal(t, strconv.FormatBool(!istio), response)
+		}),
 		in.EditFile("echo", func(content []byte) []byte {
 			return []byte(strings.ReplaceAll(string(content), "Hello", "Bye"))
 		}, "echo.go"),
@@ -70,7 +89,7 @@ func runKubeScalingTest(t *testing.T, istio bool) {
 			assert.NoError(t, err)
 			depCount := 0
 			for _, dep := range deps.Items {
-				if strings.HasPrefix(dep.Name, "dpl-echo") || strings.HasPrefix(dep.Name, "dpl-time") {
+				if strings.HasPrefix(dep.Name, "dpl-echo") {
 					depCount++
 					service, err := client.CoreV1().Services(namespace).Get(ctx, dep.Name, v1.GetOptions{})
 					assert.NoError(t, err)

backend/controller/scaling/testdata/go/naughty/ftl.toml

@@ -0,0 +1,2 @@
+module = "naughty"
+language = "go"

backend/controller/scaling/testdata/go/naughty/go.mod

@@ -0,0 +1,8 @@
+module ftl/naughty
+
+go 1.23.0
+
+replace (
+	github.com/TBD54566975/ftl => ./../../../../../..
+
+)

backend/controller/scaling/testdata/go/naughty/naughty.go

@@ -0,0 +1,29 @@
+// This is the echo module.
+package naughty
+
+import (
+	"context"
+	"fmt"
+	"io"
+	"net/http"
+	"strconv"
+)
+
+// BeNaughty attempts to ping echo directly and returns true if successful
+//
+//ftl:verb export
+func BeNaughty(ctx context.Context, endpoint map[string]string) (string, error) {
+	url := "http://" + endpoint["name"] + ":8893/healthz" // Replace with your actual URL
+
+	resp, err := http.Get(url)
+	if err != nil {
+		return fmt.Sprintf("Error making GET request: to %s %v\n", url, err), nil
+	}
+	defer resp.Body.Close()
+
+	_, err = io.ReadAll(resp.Body)
+	if err != nil {
+		return fmt.Sprintf("Error reading response body: %v\n", err), nil
+	}
+	return strconv.FormatBool(resp.StatusCode == 200), nil
+}

deployment/Justfile

@@ -60,6 +60,7 @@ install-istio:
       helm install istio-base istio/base -n istio-system --wait
       helm install istiod istio/istiod -n istio-system --wait
   fi
+  kubectl label namespace default istio-injection=enabled --overwrite
   kubectl kustomize --load-restrictor=LoadRestrictionsNone istio | kubectl apply -f -