chore: simple in memory provisioning scheduler #2815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvmakine
requested review from
a team and
deniseli
and removed request for
a team
Open
stuartwdouglas
approved these changes
Sep 25, 2024
alecthomas
reviewed
Sep 26, 2024
| } | ||
|
|
||
| // next running or pending task. Nil if all tasks are done. | ||
| func (d *Deployment) next() *Task { |
There was a problem hiding this comment.
Use optional.Option instead of nil to indicate existence.
| Desired []*provisioner.Resource | ||
| Existing []*provisioner.Resource | ||
| // populated only when the task is done | ||
| Output []*provisioner.Resource |
There was a problem hiding this comment.
I think it would be cleaner if this wasn't public, and was instead returned by Progress() once the task is complete?
| ) | ||
|
|
||
| // Task is a unit of work for a deployment | ||
| type Task struct { |
There was a problem hiding this comment.
Should all these be public? Generally I think unless a type is purely data it's preferable to have private fields and a constructor, to make it very clear what is and isn't required at construction time.
| } | ||
|
|
||
| // ExtractResources from a module schema | ||
| func ExtractResources(sch *schema.Module) ([]*provisioner.Resource, error) { |
| var result []*provisioner.Resource | ||
| for _, decl := range sch.Decls { | ||
| if db, ok := decl.(*schema.Database); ok { | ||
| if db.Type == "postgres" { |
| if existing == nil { | ||
| continue | ||
| } | ||
| if mysqlTo, ok := r.Resource.(*provisioner.Resource_Mysql); ok { |
There was a problem hiding this comment.
Is there a better pattern we can use here?
There was a problem hiding this comment.
At the very least this should be a type switch rather than a set of if/else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rough domain model for provisioning deployments.
Taskis a single executable task to bring the infra from one state to anotherDeploymentis a list of sequentially executable tasksProvisioneris an interface for calling provisioners, wrapping calls to provisioner pluginsThis is a WIP, and there are a lot of
TODOs around, but I wanted to get this out to keep PRs small.