Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: report file location of the integration test that failed #2834

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

alecthomas
Copy link
Collaborator

By adding a bunch of t.Helper() calls.

Before:

=== NAME  TestLeaseFailure/go
    /Users/alec/dev/ftl/internal/integration/harness.go:267: Timed out waiting for assertion to pass: Expected values to be equal:
        -error
        +executing

After:

=== NAME  TestLeaseFailure/go
    /Users/alec/dev/ftl/backend/controller/pubsub/integration_test.go:178: Timed out waiting for assertion to pass: Expected values to be equal:
        -error
        +executing
--- FAIL: TestLeaseFailure (22.26s)
    --- FAIL: TestLeaseFailure/go (18.18s)

@alecthomas alecthomas requested a review from a team as a code owner September 26, 2024 03:45
@alecthomas alecthomas requested review from worstell and removed request for a team September 26, 2024 03:45
@alecthomas alecthomas enabled auto-merge (squash) September 26, 2024 03:45
This was referenced Sep 26, 2024
@alecthomas alecthomas force-pushed the aat/integration-test-helper branch 3 times, most recently from 5c3c329 to 5a4fbce Compare September 26, 2024 04:15
By adding a bunch of t.Helper() calls.

Before:

```
=== NAME  TestLeaseFailure/go
    /Users/alec/dev/ftl/internal/integration/harness.go:267: Timed out waiting for assertion to pass: Expected values to be equal:
        -error
        +executing
```

After:

```
=== NAME  TestLeaseFailure/go
    /Users/alec/dev/ftl/backend/controller/pubsub/integration_test.go:178: Timed out waiting for assertion to pass: Expected values to be equal:
        -error
        +executing
--- FAIL: TestLeaseFailure (22.26s)
    --- FAIL: TestLeaseFailure/go (18.18s)

```
@alecthomas alecthomas merged commit 83a26fd into main Sep 26, 2024
91 checks passed
@alecthomas alecthomas deleted the aat/integration-test-helper branch September 26, 2024 04:45
@worstell worstell added the approved Marks an already closed PR as approved label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Marks an already closed PR as approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants