feat: enforce FTL name rules in JVM #2835
Conversation
stuartwdouglas
requested review from
a team and
deniseli
and removed request for
a team
stuartwdouglas
force-pushed
the
stuartwdouglas/2366
branch
from
84a618e
to
258d0d2
Compare
| @@ -74,6 +76,7 @@ public class ModuleBuilder { | |||
| public static final DotName OFFSET_DATE_TIME = DotName.createSimple(OffsetDateTime.class.getName()); | |||
| public static final DotName GENERATED_REF = DotName.createSimple(GeneratedRef.class); | |||
| public static final DotName EXPORT = DotName.createSimple(Export.class); | |||
| private static final Pattern NAME_PATTERN = Pattern.compile("^[A-Za-z_][A-Za-z0-9_]*$"); | |||
There was a problem hiding this comment.
The naming convention isn't quite this simple, but this is a good improvement. ie. this will allow DNSServer, but the FTL name for that would be DnsServer. I think this is very uncommon in the JVM though?
There was a problem hiding this comment.
I copied this from validator.go:
ftl/backend/schema/validate.go
Line 247 in 637f20a
Is there stricter validation somewhere? I had a look but I did not seem to be able to find it.
There was a problem hiding this comment.
Aaah!
I think that's okay. We use strcase.ToUpperCamel() for types and strcase.ToLowerCamel() for values, but they would be difficult to reproduce. What will end up happening is that when they round-trip through code-genn from the schema they'll be canonicalised to the above.
stuartwdouglas
force-pushed
the
stuartwdouglas/2366
branch
from
258d0d2
to
f4371cc
Compare
fixes: #2366