feat: add UpdateDeploy to DeployClient #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvmakine
requested review from
stuartwdouglas
and removed request for
a team
github-actions
bot
changed the title
Open
stuartwdouglas
approved these changes
Sep 26, 2024
|
While you're there you should remove uses of ftlv1connect.ControllerServiceClient from the package and replace it with DeployClient |
alecthomas
approved these changes
Sep 26, 2024
jvmakine
added
run-all
jvmakine
force-pushed
the
juho/deploy-client-update
branch
from
d0c1a00
to
566776c
Compare
jvmakine
added
the
run-all
jvmakine
force-pushed
the
juho/deploy-client-update
branch
from
6680365
to
acfda84
Compare
jvmakine
removed
the
run-all
jvmakine
force-pushed
the
juho/deploy-client-update
branch
from
acfda84
to
d90ce11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.