fix: cache HTTP routes #2868
Merged
fix: cache HTTP routes #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
requested review from
a team and
gak
and removed request for
a team
alecthomas
approved these changes
Sep 27, 2024
| @@ -1828,12 +1823,16 @@ func (s *Service) syncRoutesAndSchema(ctx context.Context) (ret time.Duration, e | |||
| } | |||
There was a problem hiding this comment.
Maybe rename this function to syncState()?
There was a problem hiding this comment.
These are still technically routes, if we end up syncing more stuff then I think we should rename it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.