feat: update ftltest for injected verb clients #2877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniseli
approved these changes
Sep 27, 2024
go-runtime/ftl/ftltest/ftltest.go
Outdated
| moduleCtx := modulecontext.FromContext(ctx).CurrentContext() | ||
| override, err := moduleCtx.BehaviorForVerb(schema.Ref{Module: ref.Module, Name: ref.Name}) | ||
| if err != nil { | ||
| return resp, fmt.Errorf("%s: %w", ref, err) |
There was a problem hiding this comment.
nit: should we make this "test harness failed to retrieve behavior for verb %s: %w" and similar make L535 something like "test harness failed to call verb %s: %w"?
alecthomas
approved these changes
Sep 27, 2024
|
Don't forget you'll need to update the customer code to use this! |
have been working this up today :) |
worstell
force-pushed
the
worstell/20240926-inject-verbs-test-changes
branch
2 times, most recently
from
9c537e5
to
b3fc9a1
Compare
|
think i'll wait til monday to merge this one because it will require customer changes, and i'd ideally like to couple those changes with the announcement/change for the new verb client stuff - which is much more invasive for a friday 😄 |
worstell
force-pushed
the
worstell/20240926-inject-verbs-test-changes
branch
from
9feb877
to
090a931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.