Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minor tweaks to module type filter #2879

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: minor tweaks to module type filter #2879

merged 1 commit into from
Sep 27, 2024

Conversation

wesbillman
Copy link
Member

Screenshot 2024-09-27 at 12 55 50 PM
Screenshot 2024-09-27 at 12 55 59 PM

@wesbillman wesbillman requested review from a team and stuartwdouglas and removed request for a team September 27, 2024 20:07
This was referenced Sep 27, 2024
Open
Open
deniseli
deniseli approved these changes Sep 27, 2024
View reviewed changes
frontend/console/src/components/Multiselect.tsx
@@ -10,6 +11,16 @@ export function sortMultiselectOpts(o: MultiselectOpt[]) {
return o.sort((a: MultiselectOpt, b: MultiselectOpt) => (a.key < b.key ? -1 : 1))
}

const getSelectionText = (selectedOpts: MultiselectOpt[], allOpts: MultiselectOpt[]): string => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is sweet

frontend/console/src/components/Divider.tsx Outdated
className?: string
}

export const Divider: React.FC<DividerProps> = ({ orientation = 'horizontal', className }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about making a prop vertical?: boolean? Then we don't have to worry about string typos not getting caught

@wesbillman wesbillman merged commit 9948608 into main Sep 27, 2024
91 checks passed
@wesbillman wesbillman deleted the tree-filter-polish branch September 27, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deniseli deniseli deniseli approved these changes

@alecthomas alecthomas Awaiting requested review from alecthomas

@stuartwdouglas stuartwdouglas Awaiting requested review from stuartwdouglas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wesbillman @deniseli