fix: imports for non-referenced external types #2880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
a team and
gak
and removed request for
a team
worstell
force-pushed
the
worstell/20240927-fix-verb-client-gen
branch
from
0ca2af7
to
3c60cff
Compare
sometimes these need to be genned even if they're not referenced by the main module, e.g. the request in an external verb for which the main module needs a client. we need to generate the client with its resolved request type
worstell
force-pushed
the
worstell/20240927-fix-verb-client-gen
branch
from
3c60cff
to
69ba831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sometimes these need to be genned even if they're not referenced by the main module, e.g. the request in an external verb for which the main module needs a client. we need to generate the client with its resolved request type