chore: integration test option to use ftl-provisioner
#2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvmakine
requested review from
a team and
gak
and removed request for
a team
Open
…oyments through the preovisioner This also adds a hidden flags --use-provisioner to deploy using the provisioner service instead of controller --provisioner-endpoint to set the provisioner endpoint
jvmakine
force-pushed
the
juho/start-provisioner-it
branch
from
17f91e5
to
bf6337b
Compare
gak
approved these changes
Sep 30, 2024
alecthomas
reviewed
Sep 30, 2024
|
|
||
| go 1.23.0 | ||
|
|
||
| replace github.com/TBD54566975/ftl => ./../../../../../.. |
There was a problem hiding this comment.
I think this might be too many path components?
alecthomas
reviewed
Sep 30, 2024
| client = rpc.ClientFromContext[provisionerconnect.ProvisionerServiceClient](ctx) | ||
| } else { | ||
| client = rpc.ClientFromContext[ftlv1connect.ControllerServiceClient](ctx) | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runs deployments through the provisioner if requested
This also adds a hidden CLI flags
--use-provisionerto deploy using the provisioner service instead of controller--provisioner-endpointto set the provisioner endpointNext, I will look how to integrate
ftl-provisionerbetter withftl serve