Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: integrate ftl-provisioner with ftl serve #2896

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

jvmakine
Copy link
Contributor

Adds a hidden parameter to ftl serve to allow embedding provisioners to it. Uses this instead of a separate binary in the integration tests.

Next, I will work on a test for provisioning a mysql resource using the cloudformation plugin and localstack

@jvmakine jvmakine requested review from alecthomas and a team as code owners September 30, 2024 03:20
@jvmakine jvmakine requested review from wesbillman and removed request for a team September 30, 2024 03:20
@ftl-robot ftl-robot mentioned this pull request Sep 30, 2024
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

backend/provisioner/service.go Outdated Show resolved Hide resolved
frontend/cli/cmd_serve.go Outdated Show resolved Hide resolved
frontend/cli/cmd_serve.go Outdated Show resolved Hide resolved
frontend/cli/cmd_serve.go Outdated Show resolved Hide resolved
@alecthomas
Copy link
Collaborator

Any thoughts on how to integrate plugins into the ftl binary too?

@jvmakine
Copy link
Contributor Author

Any thoughts on how to integrate plugins into the ftl binary too?

Not yet, but that is the next thing I am looking at. I think I will just have a built-in development provisioner for now when running locally

@jvmakine jvmakine enabled auto-merge (squash) September 30, 2024 05:32
@jvmakine jvmakine merged commit 9404a8c into main Sep 30, 2024
92 checks passed
@jvmakine jvmakine deleted the juho/serve-provisioner branch September 30, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants