Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant log messages in language plugin proto #3212

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Oct 28, 2024

We will use stdout with the json log format instead, as this matches what we do elsewhere.

@matt2e matt2e requested review from a team and alecthomas as code owners October 28, 2024 05:25
@matt2e matt2e requested review from a team and deniseli and removed request for a team October 28, 2024 05:25
@matt2e matt2e mentioned this pull request Oct 28, 2024
38 tasks
@ftl-robot ftl-robot mentioned this pull request Oct 28, 2024
@matt2e matt2e added the skip-proto-breaking PRs with this label will skip the breaking proto check label Oct 28, 2024
@matt2e matt2e force-pushed the matt2e/langplugin-to-stdout branch from 17b4e46 to 4548810 Compare October 28, 2024 05:29
@alecthomas
Copy link
Collaborator

Glorious!

@matt2e matt2e merged commit 7d74fbd into main Oct 28, 2024
91 checks passed
@matt2e matt2e deleted the matt2e/langplugin-to-stdout branch October 28, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-proto-breaking PRs with this label will skip the breaking proto check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants