chore: don't use cashapp/activate-hermit's native caching #3300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
force-pushed
the
aat/hermit-cache-fix
branch
from
386dc09
to
d739974
Compare
stuartwdouglas
approved these changes
Nov 1, 2024
alecthomas
force-pushed
the
aat/hermit-cache-fix
branch
2 times, most recently
from
844b112
to
21db077
Compare
We only write to the cache on main.
alecthomas
force-pushed
the
aat/hermit-cache-fix
branch
from
21db077
to
21ea70f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only write to the cache on main.
It also turns out we were only intermittently using the native caching anyway, so this should be more reliable.