For Credential Application processing, handle JWT and Data Integrity Creds #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2022 17:05
nitro-neal
reviewed
Oct 19, 2022
credential/manifest/model.go
Outdated
| @@ -322,6 +323,36 @@ func IsValidCredentialApplicationForManifest(cm CredentialManifest, applicationA | |||
| return nil | |||
| } | |||
|
|
|||
| // turn a generic cred into a known shape without maintaining the proof/signature wrapper | |||
| func credentialsFromInterface(genericCred interface{}) (*credential.VerifiableCredential, error) { | |||
There was a problem hiding this comment.
awesome, like if we want to refactor one day, this function can be used at the very first line in the service.
The service input gives us 'something' we instantly take that something and turn it into a *credential.VerifiableCredential. We can do this for all objects that can take different forms
There was a problem hiding this comment.
so maybe make it capital CredentialsFromInterface because I have a feeling we will use this somewhere else
There was a problem hiding this comment.
agreed...there is more refactoring to do here and moving a number of things from the service here
There was a problem hiding this comment.
moving to a new pkg in credentials called util to avoid import cycles
nitro-neal
approved these changes
Oct 19, 2022
|
added tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.