Update to Presentation Exchange v2 and Latest CM #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #248 +/- ##
==========================================
- Coverage 59.39% 59.37% -0.03%
==========================================
Files 38 38
Lines 4280 4292 +12
==========================================
+ Hits 2542 2548 +6
- Misses 1336 1340 +4
- Partials 402 404 +2
|
decentralgabe
changed the title
Comment on lines
+24
to
+25
| err = builder.SetDescription("description") | ||
| assert.NoError(t, err) |
There was a problem hiding this comment.
Should this test verify that the correct values are set when the CM is built?
nitro-neal
reviewed
Nov 4, 2022
| @@ -28,7 +28,7 @@ | |||
| "$ref": "#/definitions/descriptor" | |||
| }, | |||
| "format": { | |||
| "$ref": "https://identity.foundation/claim-format-registry/schemas/presentation-submission-claim-format-designations.json#/definitions/format" | |||
| "$ref": "http://identity.foundation/claim-format-registry/schemas/presentation-submission-claim-format-designations.json#/definitions/format" | |||
There was a problem hiding this comment.
why do we not use https?
There was a problem hiding this comment.
json schema breaks when you do 😢
added 2 commits
November 4, 2022 09:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.