Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make target optional #316

Merged
merged 4 commits into from
Mar 22, 2023
Merged

make target optional #316

merged 4 commits into from
Mar 22, 2023

Conversation

decentralgabe
Copy link
Member

fixes #314

gabe added 3 commits March 22, 2023 10:58
Merge remote-tracking branch 'origin/main' into remove-optional-target
98a7e18 
* origin/main:
  Bump github.com/multiformats/go-multibase from 0.1.1 to 0.2.0 (#313)
  Bump github.com/go-playground/validator/v10 from 10.11.2 to 10.12.0 (#311)
Merge remote-tracking branch 'origin/main' into remove-optional-target
eaab940 
* origin/main:
  ION SDK (#307)

# Conflicts:
#	wasm/static/main.wasm
merge
621cdc0
@codecov-commenter
Copy link

Codecov Report

Merging #316 (621cdc0) into main (9ef2f8d) will decrease coverage by 0.10%.
The diff coverage is 42.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
- Coverage   58.86%   58.76%   -0.10%     
==========================================
  Files          46       46              
  Lines        5124     5148      +24     
==========================================
+ Hits         3016     3025       +9     
- Misses       1570     1580      +10     
- Partials      538      543       +5
Impacted Files Coverage Δ
credential/exchange/request.go 42.31% <42.31%> (-2.14%) ⬇️

nitro-neal
nitro-neal approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@nitro-neal nitro-neal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@decentralgabe decentralgabe merged commit 1234e62 into main Mar 22, 2023
@decentralgabe decentralgabe deleted the remove-optional-target branch March 22, 2023 20:15
decentralgabe pushed a commit that referenced this pull request Mar 22, 2023
Merge remote-tracking branch 'origin/main' into bbs-plus
f1fee95 
* origin/main:
  make target optional (#316)
  ION SDK (#307)

# Conflicts:
#	go.mod
#	go.sum
#	wasm/static/main.wasm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitro-neal nitro-neal nitro-neal approved these changes

@andresuribe87 andresuribe87 Awaiting requested review from andresuribe87 andresuribe87 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Idea] Make PresentationRequest targets optional
3 participants
@decentralgabe @codecov-commenter @nitro-neal