Refactor IsValid() in did/web/web.go #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlad-tim
requested review from
decentralgabe,
nitro-neal and
andresuribe87
as code owners
|
nice to see a test case too, cool |
andresuribe87
approved these changes
May 30, 2023
did/web/web.go
Outdated
| func (d DIDWeb) Validate(ctx context.Context) error { | ||
| _, err := d.resolveDocBytes(ctx) | ||
| if err != nil { | ||
| return errors.Wrap(err, "failed to validate DID") |
There was a problem hiding this comment.
Suggested change
| return errors.Wrap(err, "failed to validate DID") | |
| return errors.Wrap(err, "resolving doc bytes") |
did/web/web_test.go
Outdated
| t.Run("Unresolvable Path - Validate DID", func(tt *testing.T) { | ||
| err := didWebNotADomain.Validate(context.Background()) | ||
| assert.Error(tt, err) | ||
| assert.Contains(tt, err.Error(), "failed to validate") |
There was a problem hiding this comment.
Prefer using
Suggested change
| assert.Contains(tt, err.Error(), "failed to validate") | |
| assert.ErrorContains(tt, err, "failed to validate") |
Codecov Report
@@ Coverage Diff @@
## main #399 +/- ##
==========================================
+ Coverage 57.22% 57.26% +0.04%
==========================================
Files 68 68
Lines 7347 7354 +7
==========================================
+ Hits 4204 4211 +7
+ Misses 2400 2399 -1
- Partials 743 744 +1
|
|
Looks like this PR now has conflicts with the mainline. I have just made an attempt to resolve them from the Github UI. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IsValid()toerror, and rename the function toValidate().context.Contextas it's first parameter and propagate it to the network call.Validate()function.Testing
Ran
mage cbtwithout any errors.References
Related to #395 .