Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable open telemetry tracing for redis #326

Merged
merged 2 commits into from
Mar 16, 2023

Conversation

andresuribe87
Copy link
Contributor

@andresuribe87 andresuribe87 commented Mar 14, 2023

Also made a couple of simple changes so tracing runs locally (whether running with docker or in the local machine). See below for an example. Redis was also instrumented.

image

@codecov-commenter
Copy link

Codecov Report

Merging #326 (2af4009) into main (de6970f) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
- Coverage   18.76%   18.73%   -0.03%     
==========================================
  Files          36       36              
  Lines        4285     4291       +6     
==========================================
  Hits          804      804              
- Misses       3361     3365       +4     
- Partials      120      122       +2     
Impacted Files Coverage Δ
pkg/storage/redis.go 56.48% <0.00%> (-1.46%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@andresuribe87 andresuribe87 marked this pull request as ready for review March 16, 2023 18:54
Copy link
Member

@decentralgabe decentralgabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@andresuribe87 andresuribe87 merged commit cfe8027 into TBD54566975:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants