Fixing context cancelled for webhook post calls #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #399 +/- ##
==========================================
- Coverage 20.43% 20.43% -0.01%
==========================================
Files 48 48
Lines 5422 5423 +1
==========================================
Hits 1108 1108
- Misses 4139 4140 +1
Partials 175 175
|
pkg/service/webhook/service.go
Outdated
| @@ -191,9 +192,9 @@ func (s Service) PublishWebhook(ctx context.Context, noun Noun, verb Verb, paylo | |||
| continue | |||
| } | |||
|
|
|||
| err = s.post(ctx, url, string(postJSONData)) | |||
| err = s.post(context.Background(), url, string(postJSONData)) | |||
There was a problem hiding this comment.
context.Background mean that this call can wait forever. This can lead to memory increasing without a bound.
Instead, I suggest to us some cancellable context.
| return | ||
| } | ||
| ctx, cancel := context.WithTimeout(context.Background(), duration) | ||
| defer cancel() | ||
| err = s.post(ctx, url, string(postJSONData)) |
There was a problem hiding this comment.
can combine with the line below
There was a problem hiding this comment.
This has changed locatoin
andresuribe87
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes an issue where we would get cancelled contexts for webhook calls