gin swagger; remove streamlit #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decentralgabe
commented
May 18, 2023
| @@ -53,6 +52,12 @@ func run() error { | |||
| logrus.Fatalf("could not instantiate config: %s", err.Error()) | |||
| } | |||
|
|
|||
| // set up some additional swagger config | |||
| doc.SwaggerInfo.Version = cfg.SVN | |||
There was a problem hiding this comment.
adding the docs.go file is necessary to do this config
Codecov Report
@@ Coverage Diff @@
## main #442 +/- ##
=======================================
Coverage 21.39% 21.39%
=======================================
Files 48 49 +1
Lines 5366 5370 +4
=======================================
+ Hits 1148 1149 +1
- Misses 4034 4037 +3
Partials 184 184
|
andresuribe87
approved these changes
May 19, 2023
.github/workflows/ci.yml
Outdated
| - name: Update spec and push generated spec file | ||
| if: github.event_name == 'pull_request' && github.event.action != 'closed' && github.event.pull_request.merged != true | ||
| run: | | ||
| mage spec |
There was a problem hiding this comment.
mage spec is also doing formatting of files. See
Lines 114 to 117 in 7047be5
I think that needs to be broken up into separate mage targets.
As it stands, you might get a passing CI during branch review, but failing in main because of this (a linter might fail).
decentralgabe
pushed a commit
that referenced
this pull request
May 20, 2023
* origin/main: gin swagger; remove streamlit (#442) # Conflicts: # pkg/server/framework/server.go # pkg/server/router/did.go # pkg/server/router/health.go # pkg/server/router/readiness.go # pkg/server/server.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #438
Cannot merge this until we figure out how to get a build user to push to main with updated swagger docs. See: https://github.com/orgs/community/discussions/25305