This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
feat:dwa-starter-vue-app-hello-word #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johnnyevans32
requested review from
finn-block,
angiejones,
blackgirlbytes,
acekyd and
EbonyLouis
as code owners
leordev
reviewed
Oct 2, 2024
There was a problem hiding this comment.
I see you added tailwind. As an optional plus, if you actually use shadcn for vue (https://github.com/radix-vue/shadcn-vue) we could leverage a lot of the existing dwa starter in react!
i see it looks pretty neat, I'll def be adding em |
leordev
reviewed
Oct 2, 2024
leordev
reviewed
Oct 2, 2024
|
finally both tests passes now! @leordev |
finn-block
reviewed
Oct 2, 2024
leordev
approved these changes
Oct 2, 2024
|
yay @Johnnyevans32 great job! I changed this issue to a |
20 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Added setup files for dwa starter vue app including readme for setting it up locally.
Related Tickets & Documents
Resolves #64
Mobile & Desktop Screenshots/Recordings
Added code snippets?
Added tests?
No tests? Add a note
Added to documentation?
No docs? Add a note
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?