Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generates the HTML to publish to GH Pages #116

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Conversation

leordev
Copy link
Member

@leordev leordev commented Dec 15, 2023

Preparing to publish to GH Pages on every new release automatically.

Preview link: https://tbd54566975.github.io/tbdex-js/index.html

image

Copy link

changeset-bot bot commented Dec 15, 2023

⚠️ No Changeset found

Latest commit: e5c73a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 15, 2023

TBDocs Report

✅ No errors or warnings

@tbdex/protocol

  • Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

  • Project entry file: packages/http-client/src/main.ts

@tbdex/http-server

  • Project entry file: packages/http-server/src/main.ts

TBDocs Report Updated at 2023-12-15T16:16:20Z e5c73a4

@leordev
Copy link
Member Author

leordev commented Dec 15, 2023

I want to add a reminder about this PR: #52

While we dont address the re-exporting of protocols on the http packages we will keep seeing duplicated definitions across the docs... http-client and http-server are replicating the protocol definitions...

image

Ideally we want it to be exactly like tbdex-kt docs: https://tbd54566975.github.io/tbdex-kt/index.html

See how lean is the http-client package:
image

cc @KendallWeihe @mistermoe

@leordev leordev merged commit e31fa7b into main Dec 19, 2023
9 checks passed
@leordev leordev deleted the leordev/gh-pages-html branch December 19, 2023 02:25
diehuxx pushed a commit that referenced this pull request Jan 4, 2024
* main:
  Remove HttpResponse and ErrorResponse from `http-client` types (#124)
  Refactor http client to introduce custom error types (#113)
  Finish validating rfq against provided offering (#120)
  Generates the HTML to publish to GH Pages (#116)
  http-server fixes + some tests (#83)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants