adding replyTo field in http request body to submit RFQ
#142
Conversation
…nd test vector change in tbdex repo and update the tbdex submodule
|
jiyoonie9
changed the title
replyTo fields inside RfqData.replyTo field in http request body to submit RFQ
|
TBDocs Report 🛑 Errors: 0 @tbdex/protocol
@tbdex/http-client
@tbdex/http-server
TBDocs Report Updated at 2024-02-05T18:04:40Z |
…create exchange handler method, wrote a test against this url check
jiyoonie9
requested review from
michaelneale,
mistermoe,
phoebe-lew,
KendallWeihe and
diehuxx
as code owners
… doc for replyTo field in SendMessagesOpts
…essage type check
| @@ -48,6 +48,27 @@ describe('POST /exchanges/:exchangeId/rfq', () => { | |||
| expect(error.detail).to.include('JSON') | |||
| }) | |||
|
|
|||
| it('returns a 400 if create exchange request contains a replyTo which is not a valid URL', async () => { | |||
There was a problem hiding this comment.
would be cool to include a test that returns a 202 if all is well
There was a problem hiding this comment.
I'm working on a slight refactor of http-server which include heeeella tests. I can add that test in my upcoming PR if it's helpful for getting this one through the door.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
+ Coverage 78.40% 78.69% +0.29%
==========================================
Files 19 19
Lines 1144 1169 +25
Branches 95 99 +4
==========================================
+ Hits 897 920 +23
- Misses 247 249 +2
|
* main: adding `replyTo` field in http request body to submit RFQ (#142)
No description provided.