Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Close to be sent after any message kind #193

Closed
wants to merge 1 commit into from

Conversation

diehuxx
Copy link

@diehuxx diehuxx commented Mar 6, 2024

I'm tentative about this change, but it seems to be the desired path forward for some who commented here TBD54566975/tbdex#242

Copy link

changeset-bot bot commented Mar 6, 2024

⚠️ No Changeset found

Latest commit: 8399ff1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 6, 2024

TBDocs Report

✅ No errors or warnings

@tbdex/protocol

  • Project entry file: packages/protocol/src/main.ts

@tbdex/http-client

  • Project entry file: packages/http-client/src/main.ts

@tbdex/http-server

  • Project entry file: packages/http-server/src/main.ts

TBDocs Report Updated at 2024-03-06T02:19:32Z 8399ff1

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Merging #193 (8399ff1) into main (67d58b9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #193      +/-   ##
==========================================
- Coverage   93.22%   93.22%   -0.01%     
==========================================
  Files          37       37              
  Lines        3011     3010       -1     
  Branches      329      329              
==========================================
- Hits         2807     2806       -1     
  Misses        204      204              
Components Coverage Δ
protocol 94.27% <100.00%> (ø)
http-client 94.83% <ø> (ø)
http-server 89.48% <ø> (-0.02%) ⬇️

@@ -16,7 +16,7 @@ export type CreateOrderOptions = {
*/
export class Order extends Message {
/** a set of valid Message kinds that can come after an order */
readonly validNext = new Set<MessageKind>(['orderstatus'])
readonly validNext = new Set<MessageKind>(['orderstatus', 'close'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're allowing close right after order?

@diehuxx diehuxx closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants