Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull resources from submodules instead of copying from submodules #139

Merged
merged 5 commits into from
Jan 31, 2024

Conversation

mistermoe
Copy link
Member

@mistermoe mistermoe commented Jan 19, 2024

TODO:

  • remove gradle tasks to copy stuff into resources
  • delete schemas from src/main/resources
  • potentially adjust github action to pull submodule

register("syncTestVectors", Sync::class) {
from("../tbdex/hosted/test-vectors/protocol/vectors")
into("./src/test/resources/test-vectors")
main {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really sure the diff between this vs using val main by getting {.. but this one works! 🤷

@jiyoontbd
Copy link
Contributor

jiyoontbd commented Jan 24, 2024

@mistermoe

potentially adjust github action to pull submodule

so we need to add some actions in ci.yaml to pull in submodule changes?

@jiyoontbd jiyoontbd marked this pull request as ready for review January 24, 2024 21:50
@jiyoontbd jiyoontbd changed the title submodule stuff Pull resources from submodules instead of copying from submodules Jan 24, 2024
@diehuxx
Copy link
Contributor

diehuxx commented Jan 24, 2024

@jiyoontbd

When checking out code in a github action you have to opt in to checking out the submodule as well. See this action in tbdex-js with submodules: true: https://github.com/TBD54566975/tbdex-js/blob/main/.github/workflows/integrity-check.yml#L43-L44

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Merging #139 (6eb1294) into main (3fba185) will increase coverage by 0.03%.
The diff coverage is 75.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   76.88%   76.91%   +0.03%     
==========================================
  Files          32       32              
  Lines         744      745       +1     
  Branches       71       71              
==========================================
+ Hits          572      573       +1     
  Misses        132      132              
  Partials       40       40              
Components Coverage Δ
protocol 85.00% <75.00%> (+0.04%) ⬆️
httpclient 77.65% <ø> (ø)

@mistermoe
Copy link
Member Author

This is good to go yeah?

@jiyoontbd
Copy link
Contributor

@mistermoe as far as i can tell, yea it is ready to go :D but needs stamps

@mistermoe
Copy link
Member Author

1 stamp from u maybe?

Copy link
Contributor

@jiyoontbd jiyoontbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😲 wow i can approve this pr

@mistermoe
Copy link
Member Author

going to go ahead and merge this. @jiyoontbd and i are aware of the changes made bc we made them together and @diehuxx is in the know about submodules and such

@mistermoe mistermoe merged commit e84ce5e into main Jan 31, 2024
4 of 7 checks passed
@mistermoe mistermoe deleted the one-submodule-to-rule-them-all branch January 31, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants