fix submitcallback to use message instead of messagetype #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-tbd
requested review from
mistermoe,
phoebe-lew,
jiyoonie9,
michaelneale,
KendallWeihe,
ethan-tbd,
tomdaffurn and
diehuxx
as code owners
|
closes #146 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 76.91% 76.91%
=======================================
Files 32 32
Lines 745 745
Branches 71 71
=======================================
Hits 573 573
Misses 132 132
Partials 40 40
|
Closed
KendallWeihe
approved these changes
Feb 2, 2024
This was
linked to
issues
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace usage of
MessageKindwithMessagein theSubmitCallbackdefinition as well as where it is used