This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
bumping web5-kt version to 0.10.0. #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… accepting JsonWebKey as assertionMethodType.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=========================================
+ Coverage 0 76.19% +76.19%
=========================================
Files 0 32 +32
Lines 0 752 +752
Branches 0 77 +77
=========================================
+ Hits 0 573 +573
- Misses 0 133 +133
- Partials 0 46 +46
|
jiyoonie9
commented
Feb 5, 2024
| @@ -41,15 +42,16 @@ class E2ETest { | |||
| keyManager, | |||
| CreateDidDhtOptions( | |||
| verificationMethods = listOf( | |||
| Pair( | |||
| Triple( | |||
There was a problem hiding this comment.
wish i could pass variable names to these like jwk = JWK.parse..., pubKey = ..., id = ...
jiyoonie9
requested review from
mistermoe,
phoebe-lew,
michaelneale,
KendallWeihe,
ethanwlee,
tomdaffurn and
diehuxx
as code owners
|
Priority PR, thanks all! @mistermoe |
|
is that security failure a net new problem? |
phoebe-lew
approved these changes
Feb 6, 2024
mistermoe
approved these changes
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed compile errors. fixed tests. accepting JsonWebKey as assertionMethodType.