This repository has been archived by the owner on Dec 12, 2024. It is now read-only.
remove allowable close after order #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirahsapong
requested review from
mistermoe,
phoebe-lew,
jiyoonie9,
michaelneale,
KendallWeihe,
ethanwlee,
tomdaffurn and
diehuxx
as code owners
angiejones
approved these changes
Mar 6, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
=======================================
Coverage 77.60% 77.60%
=======================================
Files 33 33
Lines 817 817
Branches 79 79
=======================================
Hits 634 634
Misses 137 137
Partials 46 46
|
mistermoe
approved these changes
Mar 6, 2024
KendallWeihe
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Edit: I misunderstood. Disregard below! Apologies! (we're stating that Close is not valid after Order but is valid after OrderStatus)
So the idea here being to bring to parity with tbdex-js, but to subsequently re-add support for a Close after an Order wherein the Close must have the success boolean property set, do I have that right?
(I added a summarization: TBD54566975/tbdex#242 (comment))
phoebe-lew
approved these changes
Mar 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brings to parity with tbdex-js