Add replyTo as a submitcallback function param
#197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiyoonie9
requested review from
mistermoe,
phoebe-lew,
michaelneale,
KendallWeihe,
ethan-tbd,
tomdaffurn,
diehuxx and
kirahsapong
as code owners
jiyoonie9
commented
Mar 11, 2024
| @@ -71,7 +71,7 @@ suspend fun createExchange( | |||
|
|
|||
| val offering: Offering | |||
| try { | |||
| offering = offeringsApi.getOffering(message.data.offeringId.toString()) | |||
There was a problem hiding this comment.
removed as is redundant, offeringId is string
phoebe-lew
approved these changes
Mar 11, 2024
KendallWeihe
approved these changes
Mar 11, 2024
jiyoonie9
added a commit
that referenced
this pull request
Mar 11, 2024
* fixing tests. removing ion signing test because we yeeted ion from our supported ion methods. * Add `replyTo` as a submitcallback function param (#197) * adding replyTo as submitcallback function param * adding null fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.