Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PUT for /exchanges/:exchangeId in client #214

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Use PUT for /exchanges/:exchangeId in client #214

merged 1 commit into from
Mar 28, 2024

Conversation

diehuxx
Copy link

@diehuxx diehuxx commented Mar 28, 2024

Thanks @jiyoontbd for flagging !

For the /exchanges/:exchangeId endpoint, we should be using PUT, not POST. Source

@codecov-commenter
Copy link

Codecov Report

Merging #214 (5f3b9b6) into main (14aff82) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   77.90%   77.90%           
=======================================
  Files          35       35           
  Lines         869      869           
  Branches       89       89           
=======================================
  Hits          677      677           
  Misses        142      142           
  Partials       50       50           
Components Coverage Δ
protocol 82.99% <ø> (ø)
httpclient 80.82% <100.00%> (ø)

Copy link
Contributor

@jiyoonie9 jiyoonie9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@jiyoonie9 jiyoonie9 merged commit d0cbf6e into main Mar 28, 2024
6 checks passed
@jiyoonie9 jiyoonie9 deleted the put branch March 28, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants